Prevent creation of motions with 0 reputation in domain #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronosapiens
approved these changes
May 25, 2023
kronosapiens
force-pushed
the
fix/zero-reputation-motions
branch
from
feba068 to
0cea94d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates the bug introduced in #1101, whereby if no reputation was present in a domain, a motion could still be created and would immediately become finalizable (though would not execute, as equal - zero - votes had been revealed for each side). Previously, the motion would go through the usual voting and reveal lifecycle, though without actions being able to be taken (as no reputatation exists).
While it could be argued this is desirable behaviour, it happens in a very non-standard way (with relevant timestamps being 0, and therefore in the past), it's better to prevent such useless motions from being created in the first place, which is what this PR is intending to do.