-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hardhat to 2.22 #1254
Bump hardhat to 2.22 #1254
Conversation
905c47b
to
6181c43
Compare
529bfe9
to
5271c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make arguments to getMetatransactionNonce consistent among contracts
If this is the goal, then I believe you have missed:
- ColonyNetworkAuction
- IBasicMetaTransaction
- CoinMachine
- FundingQueue
- TokenSupplier
- Whitelist
- VotingReputationStorage
- VotingReputationMisaligned
- TokenLocking
Did you not touch incrementMetatransactionNonce
because it's internal, or some other reason?
Fun to see a refactor that reduces duplication to the extent the coverage thresholds fail so more tests have to be written, that's good to see 😄
63a8b23
to
1c3d108
Compare
Thinking about this more, I'm not sure if there's much benefit to including
I say this because we already have a If anything, the UPDATE: after discussing with @area we will delete both |
913f7ad
to
55f3ef7
Compare
041303f
to
63f1a19
Compare
63f1a19
to
7782d46
Compare
fad6a77
to
87369e3
Compare
645f4ac
to
db46709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge this, but please note #1272
Closes #1228
Main
cancun
hardforkselfdestruct
and update uninstall behavior for extensionsColonyExtension.sol
base class and remove boilerplate from extension contractsMisc
reputation-test-non-gnosis
Circle job to reduce total build timesgetMetatransactionNonce
consistent among affected contracts