-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce tracing for front-end #1274
Conversation
288ca3b
to
6658977
Compare
2009361
to
3ca22cb
Compare
Added |
3ca22cb
to
d26cbc9
Compare
Hmmmm, any thoughts as to what's going on with the tests in this PR? |
@area I really don't have any idea. My first thought would be that somehow adding the |
2dba0c0
to
de76b6b
Compare
de76b6b
to
d765ca1
Compare
@area the culprit seems to be here: https://github.com/JoinColony/colonyNetwork/pull/1274/files#diff-cf4ef7c51dc9f81cad1d504da0d1c3a3437ac7b7d1374ee7127886cf1d1a5092R17 Haven't gotten to the bottom of why yet -- something about how the plugin gets initialised that affects port behavior? Perhaps you may have some insight. |
So the underlying issue is some sort of timeout somewhere in the stack, of the order of 20-30 seconds. The main call that's causing it to trigger is a I think by including I do wonder if our remaining spottiness is as a result of this (to some extent), and we're on-the-edge, so occasionally we are hit by the timeout if we get a particularly poorly performing instance on Circle. If that's the case, I would expect using From my testing, the node does not need to have the plugin for tracing to work, so there are no knock-on effects in terms of JoinColony/colonyCDapp#2691, which should continue to work as it. If we started to want to use programmatic access to traces in our tests, I could see that being a problem, but for now, I'm hopeful this is sufficient. |
Okay, now I don't know what's going on. This branch and my Am I cursed? I can't really see any common changes between the two. I have a vague solution but I'd really rather understand what's going on. |
I'm fairly sure it's running out of available memory, but I'm stuck as to why. I don't believe it's a memory leak, and it doesn't seem to be due to left over data in the |
Going back to the import style, would it be possible to do something along the lines of
Not sure if it'll solve the issue but more explicitly isolating the import might help |
I can't see how that would change things. Feel free to try, but I don't think it will solve it given the remaining test failure we are also seeing on an unrelated branch? |
Hmmmmm. So that change means that it's not including tracer when we're doing |
Add support for transaction tracing, mostly for the front-end development environment.
Companion to colonyCDapp#2691