-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/monitor-auto-restart #494
base: develop
Are you sure you want to change the base?
Conversation
Tests are failing due to Python 3.7 and the linter now using Python 3.13. Maestro is dropping support for 3.7 so I think it's time Merlin does as well. I will work on this more tomorrow. |
I will go build your branch locally and test it. |
@ryanadtran Ok, I'm in the process of writing some additional documentation too. For now, just know that you may want to run |
Updated docs for this PR can be found here: https://merlin--494.org.readthedocs.build/en/494/. The new monitor stuff (including a flow chart) is at: https://merlin--494.org.readthedocs.build/en/494/user_guide/monitoring/monitor_for_allocation/. Additionally, documentation on the new I still need to add a reference guide for the database architecture and update the "What is a results backend?" section of the docs but I don't have the brain power to do any more documentation tonight. Using this as more of a note to myself than anything. |
This PR adds in the monitor auto-restart functionality that we've been discussing @lucpeterson @ryannova @rydtran . It lays the foundation for future changes I'd like to make in Merlin involving database integration and a more OOP approach to handling backend/broker connections.
No tests have been written yet as an alpha was requested ASAP. I can add documentation and tests in the days to come but for now it's probably important to get Bogdan and Ryan Tran using this and providing feedback. If we don't want to create a full alpha release just yet, maybe we can have them just use this branch for now until I get all tests and documentation finished. I'll leave that up for discussion.