Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout for XHR requests #95

Merged
merged 2 commits into from
Jan 8, 2018
Merged

Add timeout for XHR requests #95

merged 2 commits into from
Jan 8, 2018

Conversation

BehindTheMath
Copy link
Collaborator

Closes #24.

@BehindTheMath BehindTheMath requested a review from MoOx December 22, 2017 04:02
@BehindTheMath
Copy link
Collaborator Author

I thought 600ms (see the title of #24) was a bit short, so I set the default at 10000ms, and gave the user the option of setting it manually.

@BehindTheMath
Copy link
Collaborator Author

I changed my mind, and switched the default timeout to 0 (disabled). I think it's better to give the user the ability to opt in to a timeout, instead of forcing it on them by default.

@BehindTheMath BehindTheMath merged commit 6491e32 into master Jan 8, 2018
@BehindTheMath BehindTheMath deleted the enhancement/add-xhr-timeout branch January 8, 2018 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoOx MoOx MoOx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BehindTheMath @MoOx