Move hostir and multidevice exec to PolymorphicValues.

[csarofeen]

No description provided.

[github-actions]

Review updated until commit 9f2c1d3

Description

• Replace IValue with PolymorphicValue in executor interfaces.

• Update runWithInput methods to use PolymorphicValue.

• Remove redundant runWithPolymorphicValues method.

• Update tests to use PolymorphicValue instead of IValue.

---

Changes walkthrough 📝

	Relevant files
Enhancement	executor.cpp Update runWithInput to use PolymorphicValue                            csrc/host_ir/executor.cpp Update runWithInput to accept PolymorphicValue instead of IValue. Remove runWithPolymorphicValues method. +1/-12    executor.cpp Update runWithInput to use KernelArgumentHolder                    csrc/multidevice/executor.cpp Update runWithInput to accept KernelArgumentHolder instead of IValue. Replace IValue with PolymorphicValue in input processing. +5/-5      fusion_kernel_runtime.cpp Update input mapping to use PolymorphicValue                          csrc/runtime/fusion_kernel_runtime.cpp Replace IValue with PolymorphicValue in input mapping. +2/-2      executor.h Update runWithInput signature                                                        csrc/host_ir/executor.h Update runWithInput method signature to use PolymorphicValue. Remove runWithPolymorphicValues method. +1/-3      executor.h Update runWithInput signature                                                        csrc/multidevice/executor.h Update runWithInput method signature to use KernelArgumentHolder. +1/-1
Tests	test_host_irs.cpp Update tests to use PolymorphicValue                                          tests/cpp/test_host_irs.cpp Replace IValue with PolymorphicValue in test cases. +15/-15  test_multidevice_overlap.cpp Update tests to use PolymorphicValue                                          tests/cpp/test_multidevice_overlap.cpp Replace IValue with PolymorphicValue in test cases. +4/-4      test_multidevice_pipeline.cpp Update runWithInput call                                                                  tests/cpp/test_multidevice_pipeline.cpp Update runWithInput call to use KernelArgumentHolder. +1/-1

---

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 PR contains tests

⚡ Recommended focus areas for review Function Removal The function runWithPolymorphicValues has been removed. Ensure that all functionalities previously handled by this function are now covered by runWithInput. std::vector<at::Tensor> HostIrEvaluator::runWithInput( const std::unordered_map<Val*, PolymorphicValue>& val_to_PValue) { // process input values, converting IValue to PolymorphicValue for (const auto& [val, pvalue] : val_to_PValue) { expr_evaluator_.bind(val, pvalue); } Function Signature Change The signature of runWithInput has changed from taking std::unordered_map<Val*, c10::IValue> to const std::unordered_map<Val*, PolymorphicValue>&. Verify that this change does not break any existing code that relies on the old signature. std::vector<at::Tensor> runWithInput( const std::unordered_map<Val*, PolymorphicValue>& val_to_PValue); Argument Conversion The argument passed to runWithInput has changed from args.toC10Array() to args. Ensure that KernelArgumentHolder is compatible with the new runWithInput signature. outputs = runtime->runWithInput(args);

[csarofeen]

!test

[csarofeen]

nvfuser-ci/jit_binary_tests_20_H100_3/3 — Found 1 failures after 32 minutes https://nv/eyZ/143382544
This is just a tolerance issue in the test. Safe to ignore.

[wujingyue]

cc @nsarka and @samnordmann

[naoyam]

@wujingyue Could you please take a look at this PR? It looks good to me, but I just wanted to double check with you.

[csarofeen]

!test

[naoyam]

The Thunder failure seems to be the same as #3919, for which I have a fix #3926. Not sure why it shows up in this PR but not in others.