Add recipe configs validating #10954
Conversation
Signed-off-by: BoxiangW <[email protected]>
Signed-off-by: BoxiangW <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
BoxiangW
added
Run CICD
feature
|
[🤖]: Hi @BoxiangW 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
|
[🤖]: Hi @BoxiangW 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
nemo/collections/llm/api.py
Outdated
| assert trainer.strategy.pipeline_model_parallel_size > 0 | ||
| assert trainer.strategy.context_parallel_size > 0 | ||
|
|
||
| # DP validation |
There was a problem hiding this comment.
You are assuming here that a user always uses MegatronStrategy, that's not the case. So please add some if-statements in this function
|
@maanug-nv How does this relate to your work on validation of configs? |
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
|
[🤖]: Hi @BoxiangW 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
|
Hi @marcromeyn , can you help take a look at this PR again? Thanks |
* Init with parallelism validation * Apply isort and black reformatting Signed-off-by: BoxiangW <[email protected]> * Add config checks * Apply isort and black reformatting Signed-off-by: BoxiangW <[email protected]> * fix * Add unit tests on configs validation * Add test * Add copyright * Change test * testing * Test --------- Signed-off-by: BoxiangW <[email protected]> Co-authored-by: BoxiangW <[email protected]> Signed-off-by: Youngeun Kwon <[email protected]>
What does this PR do ?
Add model config validations for NeMo 2.0
Collection: llm
Changelog
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information