Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transcribe speech #11379

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix transcribe speech #11379

merged 2 commits into from
Nov 22, 2024

Conversation

nithinraok
Copy link
Collaborator

What does this PR do ?

Adds check for timestamps when only override_cff is used.

Collection: ASR

Changelog

  • update timestamps check based on override_cfg value

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Nithin Rao Koluguri added 2 commits November 22, 2024 07:56
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.asr.models.ctc_models
nemo/collections/asr/models/ctc_models.py:196:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:197:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:813:0: C0301: Line too long (133/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:819:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:820:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:826:0: C0301: Line too long (139/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:827:0: C0301: Line too long (141/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:833:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:834:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:840:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:841:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:847:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:848:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:854:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:855:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:861:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:862:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:868:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:869:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:875:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:876:0: C0301: Line too long (143/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:882:0: C0301: Line too long (139/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:883:0: C0301: Line too long (141/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:889:0: C0301: Line too long (151/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:890:0: C0301: Line too long (162/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:897:0: C0301: Line too long (151/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:898:0: C0301: Line too long (162/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:904:0: C0301: Line too long (139/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:905:0: C0301: Line too long (146/119) (line-too-long)
nemo/collections/asr/models/ctc_models.py:545:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/ctc_models.py:602:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/ctc_models.py:620:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/ctc_models.py:662:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/ctc_models.py:680:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/ctc_models.py:916:4: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.collections.asr.models.rnnt_models
nemo/collections/asr/models/rnnt_models.py:1084:0: C0301: Line too long (164/119) (line-too-long)
nemo/collections/asr/models/rnnt_models.py:1085:0: C0301: Line too long (166/119) (line-too-long)
nemo/collections/asr/models/rnnt_models.py:230:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:705:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:803:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:820:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:888:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:896:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:1061:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/models/rnnt_models.py:1092:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.54/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

[🤖]: Hi @nithinraok 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@stevehuang52 stevehuang52 self-requested a review November 22, 2024 18:01
Copy link
Collaborator

@stevehuang52 stevehuang52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nithinraok nithinraok merged commit a153b8c into main Nov 22, 2024
326 of 476 checks passed
@nithinraok nithinraok deleted the fix_transcribe-speech branch November 22, 2024 18:04
ananthsub pushed a commit to ananthsub/NeMo that referenced this pull request Nov 25, 2024
* add explicit bracket for or operation

Signed-off-by: Nithin Rao Koluguri <nithinraok>

* add cfg arg

Signed-off-by: Nithin Rao Koluguri <nithinraok>

---------

Signed-off-by: Nithin Rao Koluguri <nithinraok>
Co-authored-by: Nithin Rao Koluguri <nithinraok>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* add explicit bracket for or operation

Signed-off-by: Nithin Rao Koluguri <nithinraok>

* add cfg arg

Signed-off-by: Nithin Rao Koluguri <nithinraok>

---------

Signed-off-by: Nithin Rao Koluguri <nithinraok>
Co-authored-by: Nithin Rao Koluguri <nithinraok>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* add explicit bracket for or operation

Signed-off-by: Nithin Rao Koluguri <nithinraok>

* add cfg arg

Signed-off-by: Nithin Rao Koluguri <nithinraok>

---------

Signed-off-by: Nithin Rao Koluguri <nithinraok>
Co-authored-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Youngeun Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants