Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

workarounds for clang-10 warnings #216

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Conversation

andrewcorrigan
Copy link
Contributor

Various warnings are triggered using clang-10 with the flag -Wdeprecated-anon-enum-enum-conversion. This PR proposes to suppress those warnings by casting to int

@alliepiper
Copy link
Collaborator

Eventually I'd like to sweep through and update the enums to static constexpr variables, but I'm okay with this workaround until then. LGTM.

@alliepiper alliepiper added this to the 1.11.0 milestone Oct 16, 2020
@alliepiper alliepiper added testing: gpuCI in progress Started gpuCI testing. testing: gpuCI passed Passed gpuCI testing. and removed testing: gpuCI in progress Started gpuCI testing. labels Oct 18, 2020
@andrewcorrigan
Copy link
Contributor Author

There's another warning that I just started seeing here:

__launch_bounds__ (int((ALT_DIGIT_BITS) ?
    ChainedPolicyT::ActivePolicy::AltUpsweepPolicy::BLOCK_THREADS :
    ChainedPolicyT::ActivePolicy::UpsweepPolicy::BLOCK_THREADS))

that can be suppressed as:

__launch_bounds__ (int((ALT_DIGIT_BITS) ?
    int(ChainedPolicyT::ActivePolicy::AltUpsweepPolicy::BLOCK_THREADS) :
    int(ChainedPolicyT::ActivePolicy::UpsweepPolicy::BLOCK_THREADS)))

Would you want that added to this PR or in a separate one?

@alliepiper
Copy link
Collaborator

DVS CL: 29265349

@alliepiper alliepiper added the testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). label Oct 30, 2020
@alliepiper
Copy link
Collaborator

Just saw your earlier comment -- let's make that a new PR. This one is close to the finish line.

@alliepiper alliepiper added testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Nov 2, 2020
@alliepiper alliepiper merged commit af39ee2 into NVIDIA:main Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants