This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
pragma unroll in block_adjacent_difference::Iterate #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @allisonvacanti |
alliepiper
added
type: enhancement
gevtushenko
approved these changes
Apr 12, 2022
| preds, | ||
| flag_op); | ||
| #pragma unroll | ||
| for (int i = ITERATION; i < MAX_ITERATIONS; ++i) { |
There was a problem hiding this comment.
Both ITERATION and MAX_ITERATIONS are fixed for these methods. These parameters depend on the ITEMS_PER_THREAD that are known in the methods. In my opinion, this creates extra brain load for readers. If you have time and @allisonvacanti doesn't object, let's remove ITERATION and MAX_ITERATIONS. Otherwise, I'll do it in a separate PR later.
alliepiper
approved these changes
Apr 22, 2022
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
Apr 22, 2022
|
gpuCI: NVIDIA/thrust#1667 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #450 (comment)