Universal Viewer #295
Open
Universal Viewer #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
update: this is a next js example listed in the UV wiki https://codesandbox.io/p/sandbox/uv-nextjs-example-uh9zi but it doesn't work for me lol |
EdwinGuzman
reviewed
Feb 21, 2025
| import { init, Viewer } from "universalviewer"; | ||
|
|
||
| export function useEvent( | ||
| viewer: Viewer | undefined, |
There was a problem hiding this comment.
Is this correct? I don't see it in the docs.
There was a problem hiding this comment.
i really don't know. code came from https://codesandbox.io/p/sandbox/uv-nextjs-example-239ff5?file=%2Flib%2Fuse-universalviewer.ts%3A9%2C26
EdwinGuzman
reviewed
Feb 21, 2025
| useEvent(uv, BaseEvents.CANVAS_INDEX_CHANGE, (i) => { | ||
| if (onChangeCanvas) { | ||
| if (lastIndex.current !== i) { | ||
| const canvas = uv?.extension?.helper.getCanvasByIndex(i); |
There was a problem hiding this comment.
This breaks but update to (uv as any)?. for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
tries to add Universal Viewer to DCFL using https://github.com/UniversalViewer/universalviewer/blob/dev/npm-examples/react-scripts/src/App.js and https://codesandbox.io/p/sandbox/uv-nextjs-example-239ff5?file=%2Fcomponents%2FUniversalViewerLazy.tsx%3A1%2C1-6%2C1
example: /items/9a3af080-2289-0132-ded5-58d385a7bbd0
Open Questions
How has this been tested? How should a reviewer test this?
Accessibility concerns or updates
Checklist: