No ref: Prep for API integration #302
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| } from "@nypl/design-system-react-components"; | ||
| import { useState } from "react"; | ||
|
|
||
| type CollectionMetadataProps = { |
There was a problem hiding this comment.
This and collectionsUUIDSchema will need to be updated once we have the list of all metadata fields being returned. this file has some initial formatting but this should definitely be abstracted out instead of hard set for each field
| push(`${pathname}?${queryString}`); | ||
| }; | ||
|
|
||
| let startValue = searchManager.filters.find((f) => f.filter === "dateStart") |
There was a problem hiding this comment.
this mix of setting the filter to the value that's currently in searchManager on mount and then managing it with state seems to work fine but is a little confusing– there might well be another way to do this. This is the same pattern used in selectFilter and rightsFilter, so it'd need to be checked in all 3 places.
| filters: searchParams.filters, | ||
| page: searchParams.page, | ||
| }); | ||
| const searchResults = |
There was a problem hiding this comment.
once the search endpoint is complete, my hope is that you can pretty much just uncomment this and then work out the bugs from there. Same on /collections/[slug]
There was a problem hiding this comment.
this whole prefetching situation can be ignored for now but the response from the collections/:uuid/children endpoint should align with what's happening here
Ticket:
no ticket, just starting point for these tickets: DR-3464, DR-3416, DR-3362
This PR does the following:
Open Questions
How has this been tested? How should a reviewer test this?
Accessibility concerns or updates
Checklist: