Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gtm #304

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add gtm #304

wants to merge 2 commits into from

Conversation

avertrees
Copy link
Collaborator

@avertrees avertrees commented Mar 11, 2025

Ticket:

This PR does the following:

  • adds Google Tag Manager to root layout.tsx file

Open Questions

How has this been tested? How should a reviewer test this?

Accessibility concerns or updates

Checklist:

  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.
  • I have updated the CHANGELOG.md.

@avertrees avertrees added the WIP Work in progress (don't merge) label Mar 11, 2025
Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
digital-collections ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 6:35pm

@@ -77,9 +77,38 @@ export default async function RootLayout({
return (
<html lang="en">
<head>
<script>
window.dataLayer = window.dataLayer || [];
{/* <!-- Google Tag Manager --> */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a typo in the code snippet. I think there should be a closing </script> here, and not on line 97. You can't have nested script tags and the code snippet that is given looks wrong. We can verify tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress (don't merge)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants