Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2181: get edition id #384

Merged
merged 2 commits into from
Oct 1, 2024
Merged

SFR-2181: get edition id #384

merged 2 commits into from
Oct 1, 2024

Conversation

ayan1229
Copy link
Contributor

@ayan1229 ayan1229 commented Oct 1, 2024

This PR verifies the following

  1. API response for /edition/{id}
  2. Verifies the returned JSON body is not null

kylevillegas93
kylevillegas93 requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@kylevillegas93 kylevillegas93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a file name change.

@ayan1229 ayan1229 merged commit 3466a2c into main Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylevillegas93 kylevillegas93 kylevillegas93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayan1229 @kylevillegas93