Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-2249: Refactor and clean up s3 file process #399

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

kylevillegas93
Copy link
Contributor

Description

  • Refactors and cleans up S3 file process
  • Adds better error handling and logging
  • Touch-up of the unit tests

Testing

make test; python main.py -p METProcess -e local -i complete -l 100; python main.py -p S3Process -e local

Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good way to refactor this process.

Copy link
Contributor

@Apophenia Apophenia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I think the logging changes will be really helpful as well.

@kylevillegas93 kylevillegas93 merged commit 49c98e4 into main Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants