Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-REF: Separating dev setup process and seed data process #402

Merged
merged 3 commits into from
Oct 17, 2024
Merged

NO-REF: Separating dev setup process and seed data process #402

merged 3 commits into from
Oct 17, 2024

Conversation

kylevillegas93
Copy link
Contributor

Description

  • Splits up the dev setup process into 2 processes - one to setup database/elastic search and one to seed data

Testing

docker compose up; python main.py -p SeedLocalDataProcess -e local

@kylevillegas93 kylevillegas93 changed the title NO-REF: Separting dev setup process and seed data process NO-REF: Separating dev setup process and seed data process Oct 16, 2024
mitri-slory
mitri-slory approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good and good catch to update the README local dev steps too.

@kylevillegas93 kylevillegas93 merged commit 2e93c41 into main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@Apophenia Apophenia Awaiting requested review from Apophenia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @mitri-slory