SFR-2277: Renaming process files and refiling ingest processes #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitri-slory
reviewed
Oct 22, 2024
| from processes.UofM import UofMProcess | ||
| from processes import UofMProcess |
There was a problem hiding this comment.
Shouldn't this line be from processes.ingest.u_of_m import UofMProcess.
There was a problem hiding this comment.
ah because the init.py file in the processes folder imports the classes from the ingest file, this still works.
There was a problem hiding this comment.
Ah ok. I was just wondering since the other tests for these processes have that code line structure.
There was a problem hiding this comment.
ya some of the errors classes are not imported in the processes module, so it needs to be the full path
There was a problem hiding this comment.
Oh appreciate the clarification
mitri-slory
approved these changes
Oct 22, 2024
Apophenia
pushed a commit
that referenced
this pull request
Oct 22, 2024
Apophenia
pushed a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
make unit; python main.py -p NYPLProcess -e local -i complete -l 10