SFR-2283: Refactoring catalog process #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apophenia
approved these changes
Oct 25, 2024
processes/catalog.py
Outdated
| logger.debug(e) | ||
| parsed_marc_xml = etree.fromstring(catalog_record.encode('utf-8')) | ||
| except Exception: | ||
| logger.exception(f'Unable to parse OCLC catalog MARC XML for OCLC number: {oclc_number}') |
There was a problem hiding this comment.
Is it worth leaving in the debug level error so that we can see the way etree failed, if it fails? I suppose it's probably a rare case
There was a problem hiding this comment.
We will see the error in the exception log! However, I think if we are debugging locally we can add more debug logs. Since we set the log level as INFO for both QA and prod, these logs never get logged out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
make test