Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-2284: Refactoring classify process #421

Merged
merged 7 commits into from
Oct 30, 2024
Merged

SFR-2284: Refactoring classify process #421

merged 7 commits into from
Oct 30, 2024

Conversation

kylevillegas93
Copy link
Contributor

@kylevillegas93 kylevillegas93 commented Oct 28, 2024

Description

  • Refactoring classify process

@kylevillegas93 kylevillegas93 marked this pull request as ready for review October 29, 2024 19:12
def __init__(self, *args):
super(ClassifyProcess, self).__init__(*args[:4], batchSize=50)

self.ingestLimit = int(args[4]) if args[4] else None
self.ingestLimit = int(args[4]) if len(args) >= 5 and args[4] else None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ingestLimit needs to stay the same because its used by the CoreProcess windowQuery function

Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes here.

@kylevillegas93 kylevillegas93 merged commit 1a28eae into main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants