Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-REF: Rename base mapping classes #440

Merged
merged 1 commit into from
Nov 12, 2024
Merged

NO-REF: Rename base mapping classes #440

merged 1 commit into from
Nov 12, 2024

Conversation

kylevillegas93
Copy link
Contributor

Description

  • Core and AbstractMapping were not clear names
  • Renames Core to BaseMapping
  • Renames AbstractMapping to RecordMapping

Testing

make unit

mitri-slory
mitri-slory approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great name changes for these classes

@kylevillegas93 kylevillegas93 merged commit 2a88966 into main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@Apophenia Apophenia Awaiting requested review from Apophenia

@samanthaandrews samanthaandrews Awaiting requested review from samanthaandrews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @mitri-slory