SFR-2352: Script to upload digital assets to Google Drive #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylevillegas93
requested review from
samanthaandrews,
mitri-slory and
Apophenia
kylevillegas93
changed the title
mitri-slory
reviewed
Nov 22, 2024
Comment on lines
+57
to
+58
| except Exception as e: | ||
| print(f'Failed to upload {file_key} to Google Drive: {e}') |
There was a problem hiding this comment.
Do we need the "e" variable here if Exception here will detail the reasons behind the error?
There was a problem hiding this comment.
yes! the print statement here won't know about the exception message by default.
There was a problem hiding this comment.
Oh that makes sense. A logger would show the exception message by default not a print statement.
mitri-slory
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
python scripts/migrate_digital_assets.py