Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2388: Adding ingest process functional tests #470

Merged
merged 2 commits into from
Dec 9, 2024
Merged

SFR-2388: Adding ingest process functional tests #470

merged 2 commits into from
Dec 9, 2024

Conversation

kylevillegas93
Copy link
Contributor

@kylevillegas93 kylevillegas93 commented Dec 6, 2024 •
edited
Loading

Description

  • Adds ingest process functional tests

Testing

pytest tests/functional

  • Note that some tests are not passing locally - will follow up on those.

mitri-slory
mitri-slory approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Once the local tests that are failing are fixed then I would say this looks good to go.

@kylevillegas93 kylevillegas93 merged commit 3f3256c into main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@Apophenia Apophenia Awaiting requested review from Apophenia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @mitri-slory