Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-2452: CLACSO Mapping #501

Merged
merged 1 commit into from
Jan 8, 2025
Merged

SFR-2452: CLACSO Mapping #501

merged 1 commit into from
Jan 8, 2025

Conversation

mitri-slory
Copy link
Contributor

This PR focuses on creating a mapping for the new source CLACSO that will soon be added to the DRB ETL pipeline for ingestion.

[('isbn', '{0}|isbn')]
,
'spatial': ('edition_location', '{0}'),
'has_part': [('url', '1|{0}|clacso|application/pdf|{{"catalog": false, "download": true, "reader": false, "embed": false}}')]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there somewhere I can read about how these pipes work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no but you bring up a good point. Is there a way we can better abstract this data format or make it more readable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it should be a better way to showcase this data format and for right now the FRBRization process needs the data to be formatted in this way so this can be a future investigation in changing the format of the data the FRBRization process receives.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Would y'all mind creating a ticket to investigate/refactor the has_part mapping logic/model when you get the chance? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackiequach to help cipher the has_part field, it's pipe delimited. The first part is the index of the part, the second part is the source, the third part is the media type, and the fourth part are the flags! The flags are the one that y'all see on the frontend to determine when to show the download and read online buttons or login!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is helpful!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Would y'all mind creating a ticket to investigate/refactor the has_part mapping logic/model when you get the chance? Thanks!

I just made a ticket addressing this: https://newyorkpubliclibrary.atlassian.net/browse/SFR-2469

@mitri-slory mitri-slory merged commit 281f11e into main Jan 8, 2025
1 check passed
@mitri-slory mitri-slory deleted the SFR-2452--CLACSO-Mapping branch January 8, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants