Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2478: Setting WEBPUB_CONVERSION_URL as a constant #514

Merged
merged 3 commits into from
Jan 14, 2025
Merged

SFR-2478: Setting WEBPUB_CONVERSION_URL as a constant #514

merged 3 commits into from
Jan 14, 2025

Conversation

kylevillegas93
Copy link
Contributor

Description

mitri-slory
mitri-slory approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. One lingering thought I have is I'm assuming the reason for converting WEBPUB_CONVERSION_URL into a constant from an environment variable is due to the variable only being used in one file in the codebase. Is that correct?

@kylevillegas93
Copy link
Contributor Author

@mitri-slory - that's correct and it's constant across local, qa and production environments!

@kylevillegas93 kylevillegas93 merged commit b85d0bf into main Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@ayan1229 ayan1229 Awaiting requested review from ayan1229

@Apophenia Apophenia Awaiting requested review from Apophenia

@jackiequach jackiequach Awaiting requested review from jackiequach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @mitri-slory