Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new google scripts #266

Merged
merged 5 commits into from
Mar 5, 2025
Merged

use new google scripts #266

merged 5 commits into from
Mar 5, 2025

Conversation

charmingduchess
Copy link
Collaborator

Description

Add new ga tags
https://newyorkpubliclibrary.atlassian.net/browse/RENO-4391

Motivation and Context

How Has This Been Tested?

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-library-card-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 4:14pm

Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing that legacy GA code! Looks good but question about an update.

const { t } = useTranslation("common");
const h1Heading = (
<Heading id="hero-banner" level="one" text={t("banner.title")} />
);
const subHeaderText = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this update necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't being used anywhere, and the linter flagged it, so I removed it

@charmingduchess charmingduchess merged commit 85a3c19 into main Mar 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants