-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new google scripts #266
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing that legacy GA code! Looks good but question about an update.
const { t } = useTranslation("common"); | ||
const h1Heading = ( | ||
<Heading id="hero-banner" level="one" text={t("banner.title")} /> | ||
); | ||
const subHeaderText = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this update necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't being used anywhere, and the linter flagged it, so I removed it
Description
Add new ga tags
https://newyorkpubliclibrary.atlassian.net/browse/RENO-4391
Motivation and Context
How Has This Been Tested?
Checklist: