Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc14 build errors with CUDA enabled #1408

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

michalkielan
Copy link
Contributor

I observed a bunch of errors when compiling vmaf with CUDA enabled. Looks like those errors were exposed when using gcc-14. Running meson with gcc-13 works fine with no issues. This PR fixes errors that prevent me from compiling: explicit casting, missing headers, unused parameter.

Repro:

$ meson libvmaf/build libvmaf -Denable_cuda=true -Denable_avx512=true
$ ninja -vC libvmaf/build

System:

$ cat /etc/redhat-release
Fedora release 41 (Forty One)
$ gcc --version
gcc (GCC) 14.2.1 20250110 (Red Hat 14.2.1-7)
Copyright (C) 2024 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Copy link
Collaborator

@nilfm99 nilfm99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nilfm99 nilfm99 merged commit 4081606 into Netflix:master Feb 12, 2025
8 checks passed
@michalkielan michalkielan deleted the fix_cuda_build branch February 12, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants