-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lf: fix panic error on systems where user is not in /etc/passwd #196614
Conversation
darwin fails with:
|
Oh ! Maybe the MacOS pure-go implementation of |
2e85984
to
e28020d
Compare
@SuperSandro2000 I now apply the fix only when not using darwin. Tell me if this works for you :) |
I just looked at ofborg and that it failed there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
e28020d
to
954335e
Compare
Description of changes
This fixes this issue which happens on systems where the user is not in
/etc/passwd
.I submitted a fix upstream (to the lf repository) that solves this problem at the package level.
This PR adds the
osusergo
build tag to the derivation which ensures that the pure go implementation ofos/user
is used instead of the one relying on libc.Indeed, the pure go implementations has a fallback for this case which consists in looking at the
$USER
and$HOME
environment variables.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes@dotlambda