Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf_25.tests.pythonProtobuf: disable faulty test #312957

Merged
merged 1 commit into from
May 20, 2024
Merged

protobuf_25.tests.pythonProtobuf: disable faulty test #312957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkgs/development/python-modules/protobuf/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ buildPythonPackage {
# https://github.com/protocolbuffers/protobuf/commit/5abab0f47e81ac085f0b2d17ec3b3a3b252a11f1
#
"google/protobuf/internal/generator_test.py"
] ++ lib.optionals (lib.versionAtLeast protobuf.version "25") [
"minimal_test.py" # ModuleNotFoundError: No module named 'google3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the interpretation that google3 is a package that comes with upb?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. Grepping through the repo just makes it look like an oversight during moving code around.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the comment to reflect that, "Refers to a non-existent module 'google3'. Presumably an oversight". An issue upstream?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned it in the commit message. My rationale was that I wanted to keep the comment short as people can always check if they get the same error message.

];

pythonImportsCheck = [
Expand All @@ -122,6 +124,6 @@ buildPythonPackage {
maintainers = with maintainers; [ knedlsepp ];
# Tests are currently failing because backend is unavailable and causes tests to fail
# Progress tracked in https://github.com/NixOS/nixpkgs/pull/264902
broken = lib.versionAtLeast protobuf.version "25";
broken = lib.versionAtLeast protobuf.version "26";
};
}