Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tree-sitter-grammars: init at 0.22.5 #320783

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

python3Packages.tree-sitter-grammars: init at 0.22.5 #320783

wants to merge 8 commits into from

Conversation

sarcasticadmin
Copy link
Member

Description of changes

As request in ngi-nix/ngipkgs#139

This generates a python binding package for each tree-sitter-grammar that exists in tree-sitter.builtGrammars.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jun 18, 2024
@sarcasticadmin sarcasticadmin force-pushed the treesitter-python-generated-grammars branch from 6937418 to 253c53f Compare June 18, 2024 13:59
@mightyiam mightyiam force-pushed the treesitter-python-generated-grammars branch from 253c53f to 1ff067a Compare June 18, 2024 14:06
@GetPsyched GetPsyched force-pushed the treesitter-python-generated-grammars branch from 1ff067a to fe9e96c Compare June 18, 2024 14:12
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 18, 2024
@mightyiam mightyiam force-pushed the treesitter-python-generated-grammars branch 2 times, most recently from 4eeaa9e to 8c63440 Compare June 19, 2024 13:52
@stepbrobd stepbrobd force-pushed the treesitter-python-generated-grammars branch from 8c63440 to 0550b06 Compare June 20, 2024 07:22
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 20, 2024
@ofborg ofborg bot requested review from mightyiam and stepbrobd June 20, 2024 07:59
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 20, 2024
@A-jay98 A-jay98 force-pushed the treesitter-python-generated-grammars branch from 0550b06 to 5947cdb Compare June 20, 2024 08:07
@adfaure adfaure force-pushed the treesitter-python-generated-grammars branch from 5947cdb to ea460ca Compare June 20, 2024 08:28
@ofborg ofborg bot requested a review from mightyiam June 20, 2024 09:12
@mightyiam
Copy link
Member

For the record, this is already ready for review, even though it's marked as draft.

@sarcasticadmin sarcasticadmin marked this pull request as ready for review June 20, 2024 12:07
@sarcasticadmin sarcasticadmin force-pushed the treesitter-python-generated-grammars branch from ea460ca to d3890e6 Compare June 20, 2024 13:51
@mightyiam mightyiam force-pushed the treesitter-python-generated-grammars branch 2 times, most recently from be0a31b to 93a9562 Compare June 20, 2024 14:23
@mightyiam mightyiam mentioned this pull request Jun 20, 2024
Open
@mightyiam mightyiam force-pushed the treesitter-python-generated-grammars branch from 93a9562 to 615c75b Compare June 24, 2024 10:03
fricklerhandwerk
fricklerhandwerk reviewed Dec 7, 2024
View reviewed changes
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the usage example from #320783 (comment) (with a properly written out shell.nix) to the Nixpkgs manual.

@adfaure
Copy link

adfaure commented Dec 7, 2024

Thank you @fricklerhandwerk for the review, I addressed most of your comments.

I still need to address the following:

Please add the usage example from #320783 (comment) (with a properly written out shell.nix) to the Nixpkgs manual.

I'll do that shortly, I just need to locate it first.

Don't we want to derive that from the Python we use for building? Or if it's fixed to 3.8 for some reason, at least use the same source for it everywhere it's referenced. See all the other hard-coded values.

Regarding Py_LIMITED_API, I don’t have the right answer yet. I need to think about it a bit more.

@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Dec 18, 2024
@adfaure adfaure force-pushed the treesitter-python-generated-grammars branch from ee55fa3 to a15eec3 Compare December 18, 2024 08:14
@nix-owners nix-owners bot requested review from GetPsyched and hsjobeki December 18, 2024 08:14
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 31, 2024
@adfaure adfaure force-pushed the treesitter-python-generated-grammars branch from 77d6268 to 786c636 Compare January 17, 2025 15:42
@adfaure adfaure force-pushed the treesitter-python-generated-grammars branch from 786c636 to d8ef65d Compare January 20, 2025 08:40
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 20, 2025
@adfaure adfaure force-pushed the treesitter-python-generated-grammars branch from d8ef65d to 05121b8 Compare January 20, 2025 08:43
adfaure and others added 5 commits January 20, 2025 09:47
@adfaure
tree-sitter/update: Run grammar tests during update process
5ea918c
@adfaure @yakampe
@GetPsyched @mightyiam @sarcasticadmin
tree-sitter-grammars: update
29c9964 
Co-authored-by: yakampe <[email protected]>
Co-authored-by: GetPsyched <[email protected]>
Co-authored-by: Shahar "Dawn" Or <[email protected]>
Co-authored-by: Robert James Hernandez <[email protected]>
@sarcasticadmin @stepbrobd
@A-jay98 @yakampe @GetPsyched @adfaure @mightyiam
python3Packages.tree-sitter-grammars: init at 0.22.5
bfa52f2 
Co-authored-by: Robert James Hernandez <[email protected]>
Co-authored-by: Yifei Sun <[email protected]>
Co-authored-by: Ali Jamadi <[email protected]>
Co-authored-by: yakampe <[email protected]>
Co-authored-by: GetPsyched <[email protected]>
Co-authored-by: Adrien Faure <[email protected]>
Co-authored-by: Shahar "Dawn" Or <[email protected]>
@adfaure
doc/packages/python-tree-sitter: add documentation
f9ec417
@adfaure
tree-sitter-grammar-markdown-inline: flag as broken
31354fa
@adfaure adfaure force-pushed the treesitter-python-generated-grammars branch from 05121b8 to 31354fa Compare January 20, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricklerhandwerk fricklerhandwerk fricklerhandwerk left review comments

@adfaure adfaure adfaure left review comments

@doronbehar doronbehar doronbehar left review comments

@Atemu Atemu Atemu left review comments

@Janik-Haag Janik-Haag Janik-Haag left review comments

@stepbrobd stepbrobd Awaiting requested review from stepbrobd

@mightyiam mightyiam Awaiting requested review from mightyiam

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@wegank wegank Awaiting requested review from wegank

@natsukium natsukium Awaiting requested review from natsukium

@GetPsyched GetPsyched Awaiting requested review from GetPsyched

@hsjobeki hsjobeki Awaiting requested review from hsjobeki

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.