Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ficsit-cli: init at v0.6.0, maintainers: add weirdrock #368980

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

weirdrock
Copy link

@weirdrock weirdrock commented Dec 29, 2024

Adds https://github.com/satisfactorymodding/ficsit-cli, a mod manager for Satisfactory. Also adds me as a maintainer. @Vilsol is a project developer and requested to be added.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 29, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 29, 2024
@weirdrock weirdrock marked this pull request as draft December 29, 2024 02:43
@weirdrock weirdrock marked this pull request as ready for review December 29, 2024 02:48
Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Nixpkgs 💜 Some suggestions:

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Dec 29, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 30, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 31, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 1, 2025
@Tert0
Copy link
Member

Tert0 commented Jan 28, 2025

Works for me on x86_64-linux with Steam Install of Satisfactory.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368980


x86_64-linux

✅ 1 package built:
  • ficsit-cli

@FliegendeWurst FliegendeWurst marked this pull request as draft February 8, 2025 10:17
@weirdrock weirdrock marked this pull request as ready for review February 22, 2025 23:18
@weirdrock weirdrock marked this pull request as draft February 22, 2025 23:18
@weirdrock weirdrock marked this pull request as ready for review February 22, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants