Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rails-new: init at 0.5.0 #378144

Closed
wants to merge 798 commits into from
Closed

rails-new: init at 0.5.0 #378144

wants to merge 798 commits into from
+14,011 −8,653

Conversation

coat
Copy link

@coat coat commented Jan 30, 2025

Adds a new package for rails-new, which enables users to create new Ruby on Rails projects without needing Ruby installed by running rails new in a Docker container.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 30, 2025
@coat coat changed the title Rails new rails-new: init at 0.5.0 Jan 30, 2025
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 30, 2025
ethancedwards8
ethancedwards8 suggested changes Feb 21, 2025
View reviewed changes
pkgs/by-name/ra/rails-new/package.nix Outdated
src = fetchFromGitHub {
owner = "rails";
repo = "rails-new";
rev = "v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag

@coat coat requested a review from ethancedwards8 February 22, 2025 23:32
ethancedwards8
ethancedwards8 suggested changes Feb 22, 2025
View reviewed changes
Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to squash your commits

@coat coat force-pushed the rails-new branch 2 times, most recently from 04992f7 to 94b39a5 Compare February 24, 2025 03:41
@github-actions github-actions bot added 6.topic: xfce The Xfce Desktop Environment 6.topic: fetch 6.topic: nodejs 6.topic: hardware 6.topic: coq "A formal proof management system" 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 6.topic: lua 6.topic: docker tools 6.topic: systemd 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: LXQt The Lightweight Qt Desktop Environment 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: vscode 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: games 6.topic: rocm 6.topic: julia 6.topic: php 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET labels Feb 24, 2025
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 24, 2025
@github-actions github-actions bot added 6.topic: nvidia 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: teams Relating to team creation, updates, other management actions 8.has: documentation This PR adds or changes documentation backport release-24.11 Backport PR automatically labels Feb 24, 2025
@coat coat closed this Feb 24, 2025
@ethancedwards8
Copy link
Member

rip.

@coat
Copy link
Author

coat commented Feb 24, 2025

rip.

I really screwed this branch up somehow, my bad. Appreciate the help, I'll try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethancedwards8 ethancedwards8 ethancedwards8 requested changes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: coq "A formal proof management system" 6.topic: docker tools 6.topic: dotnet Language: .NET 6.topic: emacs Text editor 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: fetch 6.topic: games 6.topic: hardware 6.topic: haskell 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: julia 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: kernel The Linux kernel 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: lua 6.topic: LXQt The Lightweight Qt Desktop Environment 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 6.topic: nodejs 6.topic: nvidia 6.topic: ocaml 6.topic: php 6.topic: python 6.topic: qt/kde 6.topic: rocm 6.topic: rust 6.topic: systemd 6.topic: teams Relating to team creation, updates, other management actions 6.topic: vim 6.topic: vscode 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle! backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.