firefox: fix file collisions between different flavors #378436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 0
nix-owners
bot
requested review from
lovesegfault,
squalus,
DominicWrege,
mweinelt,
christoph-heiss,
nbp,
vcunat and
jopejoe1
Each derivation flavor should use its own app bundle name. Closes: NixOS#378433 TODO: confirm thunderbird is fixed too. (May need adjustment to bundle names using applicationName argument.) Signed-off-by: Ihar Hrachyshka <[email protected]>
booxter
force-pushed
the
firefox-fix-macos-file-collisions
branch
from
95aa425 to
90ba788
Compare
|
Wrapping this into #377863 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each derivation flavor should use its own app bundle name.
Closes: #378433
TODO: confirm thunderbird is fixed too. (May need adjustment to bundle
names using applicationName argument.)
Signed-off-by: Ihar Hrachyshka [email protected]
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.