-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phpPackages.psalm: 6.5.0 -> 6.8.6 #384574
Conversation
|
If I'm not mistaken the error comes from composer itself. PHP 8.1 support requires composer LTS(2.2.X). |
The embedded |
Do we even need multiple versions? Maybe we could just move it to by-name like phpunit? |
I would then ask the @NixOS/php team for this decision as it might have a bigger impact. |
If not could we at least mark it as broken on 8.1? |
yes, going to mark it as broken for PHP 8.1. |
3354791
to
4941e0a
Compare
I got the confirmation from @danog (vimeo/psalm@15731ea#r152900744) that building the PHAR with PHP 8.1 is not working due to a bug in Humbug/Box. Marking it as broken for PHP 8.1 is definitely the way to go then, I don't really want to maintain a custom |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.