Remove metadata from sent buffer #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mionsz
reviewed
Aug 8, 2024
build.sh
Outdated
| cmake -B "${SCRIPT_DIR}/out" \ | ||
| -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" \ | ||
| -DCMAKE_INSTALL_PREFIX="${INSTALL_PREFIX}" \ | ||
| -DENABLE_ZERO_COPY=OFF \ |
There was a problem hiding this comment.
why disable zero copy?
Rest seems rather ok
There was a problem hiding this comment.
It causes data corruption. I don't know if the fault is on the MCM side or MTL, but it is highly possible that the issue is in MTL. More investigation is needed, and disabling zero copy is only a temporary fix.
There was a problem hiding this comment.
I removed this part as it is fixed in #174
Mionsz
previously approved these changes
Aug 8, 2024
Sakoram
force-pushed
the
Fix-in/out-files-size-difference
branch
from
954bc2d to
e5bc107
Compare
Video data was overwritten with metadata, which resulted in not enough data being sent Signed-off-by: Kasiewicz, Marek <[email protected]>
Sakoram
force-pushed
the
Fix-in/out-files-size-difference
branch
from
e5bc107 to
dce72e8
Compare
Mionsz
approved these changes
Aug 9, 2024
ko80
pushed a commit
to ko80/Media-Communications-Mesh
that referenced
this pull request
Aug 21, 2024
Video data was overwritten with metadata, which resulted in not enough data being sent Signed-off-by: Kasiewicz, Marek <[email protected]>
tszumski
pushed a commit
to tszumski/Media-Communications-Mesh
that referenced
this pull request
Aug 29, 2024
Video data was overwritten with metadata, which resulted in not enough data being sent Signed-off-by: Kasiewicz, Marek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video data was overwritten with metadata, which resulted in not enough data being sent