Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create script to prepare env for RDMA #187

Merged
merged 14 commits into from
Sep 25, 2024

Conversation

staszczuk
Copy link
Collaborator

This pull request contains the following commits:

  • Create script to prepare env for RDMA

Copy link
Collaborator

@Mionsz Mionsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make finish the review - as now I've done at most 50% - later today probably

Copy link
Collaborator

@Mionsz Mionsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it seems ok :). Waiting for one more review and I will give approve.

Copy link
Collaborator

@MateuszGrabuszynski MateuszGrabuszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions

staszczuk and others added 5 commits September 17, 2024 11:19
Co-authored-by: Mateusz Grabuszyński <[email protected]>
Signed-off-by: Paweł Staszczuk <[email protected]>
Co-authored-by: Mateusz Grabuszyński <[email protected]>
Signed-off-by: Paweł Staszczuk <[email protected]>
Signed-off-by: Paweł Staszczuk <[email protected]>
Signed-off-by: Paweł Staszczuk <[email protected]>
Signed-off-by: Paweł Staszczuk <[email protected]>
Copy link
Collaborator

@MateuszGrabuszynski MateuszGrabuszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@Mionsz Mionsz added enhancement New feature or request maintainers review request Pull request is ready to be reviewed. labels Sep 19, 2024
Copy link
Collaborator

@ko80 ko80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Sakoram Sakoram merged commit 04ba4b8 into OpenVisualCloud:main Sep 25, 2024
8 checks passed
Sakoram pushed a commit that referenced this pull request Sep 26, 2024
Create script to prepare env for RDMA

Signed-off-by: Pawel Staszczuk <[email protected]>
Signed-off-by: Paweł Staszczuk <[email protected]>
Co-authored-by: Mateusz Grabuszyński <[email protected]>
Sakoram pushed a commit that referenced this pull request Sep 26, 2024
Create script to prepare env for RDMA

Signed-off-by: Pawel Staszczuk <[email protected]>
Signed-off-by: Paweł Staszczuk <[email protected]>
Co-authored-by: Mateusz Grabuszyński <[email protected]>
soopel pushed a commit that referenced this pull request Sep 26, 2024
* Fix how threads are canceled

Resources may not have been deallocated at all or
deallocated while the thread was still running

Signed-off-by: Kasiewicz, Marek <[email protected]>

* Don't print error if pthread_join() returns ESRCH

ESRCH means the thread has already exited

Signed-off-by: Kasiewicz, Marek <[email protected]>

* Add memif_buffer_alloc_timeout()

Remove unnecessary pacing from sender_app
Increase ring size for RDMA
Improve test-rdma.sh

Signed-off-by: Kasiewicz, Marek <[email protected]>

* Make memif_buffer_alloc_timeout() more readable

Co-authored-by: Konstantin Ilichev <[email protected]>
Signed-off-by: Kasiewicz, Marek <[email protected]>

* MCM st22 fix to media_proxy segfault

MCM st22 fix to media_proxy segfault:
- added fix for media_proxy exit with segfault

Signed-off-by: Milosz Linkiewicz <[email protected]>

* Update README with libfabric dependencies

Signed-off-by: Kasiewicz, Marek <[email protected]>

* Create script to prepare env for RDMA (#187)

Create script to prepare env for RDMA

Signed-off-by: Pawel Staszczuk <[email protected]>
Signed-off-by: Paweł Staszczuk <[email protected]>
Co-authored-by: Mateusz Grabuszyński <[email protected]>

* Print throughput in sample apps

Signed-off-by: Kasiewicz, Marek <[email protected]>

* Add libfabric installation to setup_rdma_env.sh

Update README

Signed-off-by: Kasiewicz, Marek <[email protected]>

* Revert memif_buffer_alloc_timeout usage in mtl.c

This change was made after the code freeze and
is not critical enough to add it to the release.

Signed-off-by: Kasiewicz, Marek <[email protected]>

* Improve pthread_cancel() err handling

pthread_cancel can only return ESRCH or success.
ESRCH means that the thread is not running, which
is not an error for us.

Signed-off-by: Kasiewicz, Marek <[email protected]>

---------

Signed-off-by: Kasiewicz, Marek <[email protected]>
Signed-off-by: Milosz Linkiewicz <[email protected]>
Signed-off-by: Pawel Staszczuk <[email protected]>
Signed-off-by: Paweł Staszczuk <[email protected]>
Co-authored-by: Konstantin Ilichev <[email protected]>
Co-authored-by: Milosz Linkiewicz <[email protected]>
Co-authored-by: Paweł Staszczuk <[email protected]>
Co-authored-by: Mateusz Grabuszyński <[email protected]>
@staszczuk staszczuk deleted the rdma_script branch March 3, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintainers review request Pull request is ready to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants