Cleanup Admin Menu

[MikeAlhayek]

This PR should reduce allocations and provide a slight better performance.

INavigationProvider are called on every request to the admin page. So if we create new object every time, we have to create a new allocation every request for every client. So here we would reduce multiple allocations.

Also, since the admin menu is something we call, there is no need to check for string invariant.

• We do not need to performance a invariant check for the admin and adminMenu
• We don't need to create new object every time.

[Piedone]

While again I agree that it should be better, did you measure the impact?

[MikeAlhayek]

While again I agree that it should be better, did you measure the impact?

@Piedone I did not measure the performance difference here. However, the INavigationProvider is called on every request. saving allocating these objects for long time make scene to me since they can be accessed by all tenants and we only have to create them once.

[Piedone]

I don't disagree, but since performance issues are complex and full of surprises, we shouldn't act solely on theory.

[MikeAlhayek]

@Piedone so you good with this PR?

[Piedone]

Not yet, we still need measurements. Knowing OrchardCore.CustomSettings.AdminMenu is great, but that was one class with something unique, while there are a lot more with the anonymous object instantiation -> static RouteValueDictionary pattern of change. I don't expect that to be worse, but still.

[MikeAlhayek]

@Piedone not sure what you want to measure here. The rest of the changes either we remove the initialization completely, or we create an object once and reuse it every time. Do you have an idea for benchmarking that you want me to try?

[MikeAlhayek]

@Piedone I just did a benchmark to see how much memory allocation is saved over 100k requests one a single object initialization

Does this paint the picture or are there a specific test you have in mind. Its actually quite nice to be able to see these number and the amount of memory allocation you save with small tricks. as simple as one constant variable saves 12mb in memory allocation over 100k requests.

[Piedone]

Awesome!