Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templates file conflicts #16733

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Fix templates file conflicts #16733

merged 5 commits into from
Sep 16, 2024

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Sep 16, 2024

Fix #16734

These files in templates.config/ in OC are generated by an msbuild task from templates.config.src/. These should not be added to source control. I assume they were added by mistake after a global version update.

# Conflicts:
#	src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Cms.Module/.template.config.src/dotnetcli.host.json
#	src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Mvc.Module/.template.config.src/dotnetcli.host.json
#	src/Templates/OrchardCore.ProjectTemplates/content/OrchardCore.Templates.Mvc.Web/.template.config.src/dotnetcli.host.json
@MikeAlhayek
Copy link
Member

@Piedone a while back you requested that these are added. Can you please check this out to make sure we are not missing anything?

@MikeAlhayek MikeAlhayek requested a review from Piedone September 16, 2024 22:35
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the issue template.

FWIW I did not request these to be added. These have been there for years, I only added docs about having to update them (or perhaps Hisham did, but in any case, that's when I got involved).

@MikeAlhayek MikeAlhayek enabled auto-merge (squash) September 16, 2024 23:13
@MikeAlhayek MikeAlhayek merged commit b3c4b46 into main Sep 16, 2024
6 checks passed
@MikeAlhayek MikeAlhayek deleted the sebros/templates branch September 16, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project build keep on generating the template.json file
3 participants