Add DisableMulticastLoopback option to client parameters #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d83f28b.
…olang.org/x/net/context." This reverts commit 718390f.
This reverts commit 00d9bc3.
Setting this option to false (default) sets the IP_MULTICAST_LOOP socket option to true on the multicast sockets opened by the mDNS server. This is necessary for other sockets on the same machine to receive packets sent by the server and thus discover the service.
…can be used for a watcher
Clean up probe goroutine when shutting down
Fix domain lookup in some cases
When the timeout it reached, the query can still fail to complete if the caller isn't consuming the results from the channel. This change allows the query to exit in any case.
…tConsume Allow timeout to complete
Introduce context.Context to enable cancellation in addition to the existing timeout functionality. To retain compatability, Timeout is still available but will only be used if Context is not set. We use x/net/context.Context for the moment instead of context.Context in order to avoid creating a requirement on Go 1.7
Allow timeout and cancellation via context.Context
This reverts commit d83f28b.
…olang.org/x/net/context." This reverts commit 718390f.
This reverts commit 00d9bc3.
Setting this option to false (default) sets the IP_MULTICAST_LOOP socket option to true on the multicast sockets opened by the mDNS server. This is necessary for other sockets on the same machine to receive packets sent by the server and thus discover the service.
Setting this option to false (default) sets the IP_MULTICAST_LOOP socket option to true on the multicast sockets opened by the mDNS server. This is necessary for other sockets on the same machine to receive packets sent by the server and thus discover the service. Conflicts: server.go
Conflicts: server.go
Merge from micro/mdns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashicorp#33