fix parseNvidiaNumaInfo index out of range #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bin <[email protected]>
flpanbin
force-pushed
the
fix-numa-index-out-of-range
branch
from
bb51f01 to
816a96c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a potential array index out of bounds issue in the
parseNvidiaNumaInfofunction. The issue occurs when accessing NUMA Affinity data for the target GPU where the row has fewer columns than expected.Current code assumes the NUMA Affinity column exists in every row, but when processing the target GPU's data, if this column is missing, it will cause an index out of bounds panic.
The fix adds proper bounds checking before accessing the NUMA Affinity value, making the NVIDIA device plugin more robust when handling various topology output formats.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: