pyo3-ffi: expose PyThreadState_GetFrame and PyFrame_GetBack #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Jan 19, 2025
pyo3-ffi/src/pystate.rs
Outdated
| @@ -66,6 +67,12 @@ extern "C" { | |||
| // skipped non-limited / 3.9 PyThreadState_GetFrame | |||
There was a problem hiding this comment.
This comment should be removed I suppose.
yoav-orca
force-pushed
the
expose_getframe_and_getcode
branch
2 times, most recently
from
533d05c to
2696147
Compare
yoav-orca
force-pushed
the
expose_getframe_and_getcode
branch
from
2696147 to
a20f6a8
Compare
davidhewitt
approved these changes
Jan 24, 2025
Comment on lines
91
to
+93
| // skipped _PyFrame_DebugMallocStats | ||
| // skipped PyFrame_GetBack | ||
| #[cfg(all(Py_3_9, not(PyPy)))] | ||
| pub fn PyFrame_GetBack(f: *mut PyFrameObject) -> *mut PyFrameObject; |
There was a problem hiding this comment.
It looks like this function was moved to pyframe.h in upstream CPython. We should log a follow up to sync this sometime.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on writing (another) profiler in rust for python.
This PR exposes the functions required for unwinding the stack.