Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spurious 0 complex part in Pauli evolution #13643

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix spurious 0 complex part in Pauli evolution #13643

merged 1 commit into from
Jan 10, 2025

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Jan 9, 2025

Summary

Fixes #13642.

Details and comments

This boils down to the fact that, x * (1+0j) = 1.0*x + 0.0*I but pre-1.3 we only multiplied by 1.

@Cryoris @ElePT
fix the 0 complex part
87f79f0 
Co-authored-by: Elena Peña Tapia <[email protected]>
@Cryoris Cryoris added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jan 9, 2025
@Cryoris Cryoris added this to the 1.3.2 milestone Jan 9, 2025
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12693375478

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.008%) to 88.925%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/synthesis/evolution/suzuki_trotter.py 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
crates/circuit/src/converters.rs 1 95.65%
crates/accelerate/src/sabre/heuristic.rs 1 32.87%
crates/accelerate/src/basis/basis_translator/mod.rs 1 87.44%
crates/accelerate/src/sabre/mod.rs 2 75.44%
crates/qasm2/src/lex.rs 3 92.98%
qiskit/synthesis/evolution/product_formula.py 5 89.58%
Totals Coverage Status
Change from base Build 12687984222: -0.008%
Covered Lines: 79434
Relevant Lines: 89327
💛 - Coveralls

@ElePT ElePT added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jan 10, 2025
ElePT
ElePT approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this pull request to the merge queue Jan 10, 2025
Merged via the queue into Qiskit:main with commit 2476188 Jan 10, 2025
18 checks passed
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
@Cryoris @mergify
fix the 0 complex part (#13643)
967ad6a 
Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit 2476188)
@mergify mergify bot mentioned this pull request Jan 10, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2025
@mergify @Cryoris
fix the 0 complex part (#13643) (#13646)
bc3c7ed 
Co-authored-by: Elena Peña Tapia <[email protected]>
(cherry picked from commit 2476188)

Co-authored-by: Julien Gacon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

@alexanderivrii alexanderivrii Awaiting requested review from alexanderivrii

@ShellyGarion ShellyGarion Awaiting requested review from ShellyGarion

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.

PauliEvolutionGate introduces sneaky complex part in parameter expression coefficients
4 participants
@Cryoris @qiskit-bot @coveralls @ElePT