Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling different frame type for Streaming data source #152

Merged
merged 6 commits into from
Jan 28, 2021
Merged

Add handling different frame type for Streaming data source #152

merged 6 commits into from
Jan 28, 2021

Conversation

asimonok
Copy link
Contributor

No description provided.

@asimonok asimonok requested a review from mikhail-vl January 27, 2021 13:09
@codecov
Copy link

codecov bot commented Jan 27, 2021 •
edited
Loading

Codecov Report

Merging #152 (a1db0cd) into master (6c25f10) will increase coverage by 0.35%.
The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   93.24%   93.59%   +0.35%     
==========================================
  Files          29       33       +4     
  Lines        1258     1281      +23     
  Branches       61       65       +4     
==========================================
+ Hits         1173     1199      +26     
  Misses         73       73              
+ Partials       12        9       -3
Impacted Files Coverage Δ
src/data-source.ts 93.33% <92.30%> (+5.09%) ⬆️
src/frame-formatters/data.ts 100.00% <100.00%> (ø)
src/frame-formatters/index.ts 100.00% <100.00%> (ø)
src/frame-formatters/time-series.ts 100.00% <100.00%> (ø)
src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c25f10...d3e1f73. Read the comment docs.

@mikhail-vl mikhail-vl self-assigned this Jan 28, 2021
@mikhail-vl mikhail-vl added the enhancement New feature or request label Jan 28, 2021
@mikhail-vl mikhail-vl added this to the Version 1.3.1 milestone Jan 28, 2021
mikhail-vl
mikhail-vl suggested changes Jan 28, 2021
View reviewed changes
@mikhail-vl mikhail-vl self-requested a review January 28, 2021 07:38
mikhail-vl
mikhail-vl approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl changed the title Add handling different frame type for data source Add handling different frame type for Streaming data source Jan 28, 2021
@mikhail-vl mikhail-vl merged commit d3c8905 into master Jan 28, 2021
@mikhail-vl mikhail-vl deleted the feat/data-frame-formatter branch January 28, 2021 07:42
@mikhail-vl mikhail-vl linked an issue Jan 30, 2021 that may be closed by this pull request
Time series does not work when streaming is turned on #147
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@mikhail-vl mikhail-vl

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 1.3.1
Development

Successfully merging this pull request may close these issues.

Time series does not work when streaming is turned on
2 participants
@asimonok @mikhail-vl