Check now both on ASSERT and CHECK issue #610 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test to check that both ASSERT and CHECK is checked. Removed filter in constructor. Added filter to where condition in loop in inspect_tokens
|
|
Change the test class to move the ASSERT and CHECK to the 2nd and 3th
Error in test for check
bjoern-jueliger-sap
approved these changes
Jan 11, 2024
|
Is it expected that I do something before the fix will be pulled into the main branch? |
|
No, was I just performing some more tests to make sure this doesn't produce any undesired side effects. Merging now - thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test to check that both ASSERT and CHECK is checked. Removed filter in constructor.
Added filter to where condition in loop in inspect_tokens