Add support for --partials-dir #974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, partials were discovered by first checking `./partials` and then `../partials`. However, we can unlock easier sharing of partials with the ability to provide your own partials directory that is checked first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, partials were discovered by first checking
./partialsand then../partials. However, we can unlock easier sharing of partials with the ability to provide your own partials directory that is checked first.What are you trying to accomplish with this PR?
The ability to include partials from non-standard/hard-coded partial paths (ie:
./partialsand../partials) via a command-line parameter of--partials-dir.How is this accomplished?
When a
--partials-diris included, it's prepended to the@partials_dirsin theRenderer, and consequently is used first (if the partials are present).What could go wrong?
🤔 -- the test coverage in this area is pretty good, and I've maintained all existing test behaviours. I think the worst case, is failing to render templates.