Skip to content

Feature: When file being edited has unsaved changes, ask for confirmation before closing the edit dialog #3697

Open
@awa-xima

Description

ElFinder includes many editors for editing files directly within the file explorer. When a file has unsaved changes and the user closes the edit dialog, ElFinder currently first closes the dialog, then asks the user whether they want to save their changes:

confirmAfterClose.webm

We received feedback by our users that this is unintuitive. Instead, ElFinder should keep the dialog open and ask the user whether they want to cancel the operation (keeps the edit dialog open), discard their changes, or save their changes. This is also the behavior of many other text editors. To illustrate, ElFinder should behave like this:

confirmBeforeClose.webm

I'll open a PR for this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions