Description
Describe the bug
TUIImageEditor stops working when switching to a different working directory.
To Reproduce
Screen.Recording.2025-01-31.141503.mp4
Steps to reproduce the behavior:
- Go to https://studio-42.github.io/elFinder/
- Open a writable folder with an image
- Edit the image in the TUIImageEditor
- Exit full screen mode via the toolbar at the top right
- Use the file explorer's tree to switch to a different working directory
- Focus the TUIImageEditor again and either click
save
or close the dialog
This now logs an error on the console, and the file is not saved. Also, trying to open an image with the TUIImageEditor again fails, probably since the editor was never properly closed.
Expected behavior
Saving and closing works even when inside a directory different from the directory that contains the image.
E.g. the text area editor does not seem to have this issue.
Additional context
As you can see in the screencast fm.files()
does not include the image file when inside a different working directory. The TUIImageEditor, however, tries to access the file via fm.file(hash)
. This returns undefined, which the editor does not handle properly:
elFinder/js/extras/editors.default.js
Lines 465 to 466 in 7544918
Activity