-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for .cz and .me domain expiration #24
Conversation
…ToUpper(value) for consistent date formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that I added default values when there is no domain status or name server But it doesn't seem correct to add default values. In the case of .cz domains, the WHOIS response doesn't return a domain status. How should we handle this? The test expects at least one status, and we're getting a failure when it's missing. What would be the best approach for this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- FAIL: TestClient/name.cz_Query (0.52s)
whois_test.go:120: expected name.cz in output, got Your connection limit exceeded. Please slow down and try again later.
--- FAIL: TestClient/name.cz_QueryAndParse (0.34s)
whois_test.go:136: expected to have a valid expiry date, got -62135596800 for domain name.cz
whois_test.go:139: expected to have at least one name server for domain name.cz
whois_test.go:145: Skipping domain status check for .cz: name.cz
🤔
… removed .me from tldWithoutExpirationDate
… removed .me from tldWithoutExpirationDate
Fix: Added support for .cz TLD, updated expiration date handling, and removed .me from tldWithoutExpirationDate
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed .me from the list of TLDs that are exempt from expiration date checks.
Added case for .cz TLD to handle expiration date parsing with custom format (dd.MM.yyyy).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added case for .cz and .me.
Added exception for domain cz
Summary
Add support for .cz and .me domain expiration
Checklist
README.md
, if applicable.