Intermittently failing tests

[orenyk]

We currently have three tests that fail intermittently, both locally and on Travis. They include two tests from app_configs_controller_spec.rb and one test from delete_missed_reservation_rake_spec.rb. We should figure out why they fail, only sometimes, and fix it so our test suite is always green.

[orenyk]

For example, the latest master build (#1750) failed four times before finally passing (mostly the rake test).

[caseywatts]

We can either:

1. Debug this (which will take an unknown amount of time)
2. Comment these out for now (intermittent tests are bad tests, just distracting not helpful) with a comment noting that they were intermittent.

[squidgetx]

I especially think the intermittently failing appconfig tests are kind of irrelevant

[orenyk]

Agreed. Have you noticed the rake task one failing as well, or was that just Travis and me?

[squidgetx]

No, I saw that one as well. Haven't looked super carefully at it yet but it could easily be another time zone thing

[orenyk]

Of course, now that I'm trying to mess with this I can't get the tests to fail. I suspect the rake test might be a timing issue... it's possible that the db isn't finished updating before the assertion is made. I've added a sleep 1 between the rake call and the expectation and we'll see if that fixes things.