Unable to render cart if Equipment Models in cart destroyed no longer in DB

[orenyk]

Steps to replicate:

1. Seed DB
2. Add item to cart (e.g. cart.items[n] = 1)
3. Destroy the relevant EquipmentModel (e.g. EquipmentModel.find(n).destroy(:force))
4. Try to render catalog

The issue is that we're trying to render a link to remove an item from the cart but that item doesn't exist so link_to is throwing an exception. I'd recommend we simply check for this case in the cart method and remove items from the hash if necessary before passing it over to the view, e.g.:

def cart
...
session[:cart].items.each do |key, count|
  session[:cart].items.delete(key) unless EquipmentModel.find_by_id(key)
end
...

Something like that, anyway.

[squidgetx]

[orenyk]

I don't understand your image replies :-P

[orenyk]

Reference to "antenna-gate"?

[squidgetx]

No, it's an edge case! :D

[orenyk]

Ha awesome. This is done, I made a separate method to conform to rubocops AbcSize checking.