Import Users raises NoMethodError post-import

[orenyk]

Steps to replicate:

1. Create CSV with user information
2. Attempt to import users
3. Get the following:

This was reported by a user on v3.4, so I guess we have a missed regression. We should fix this in v4.3.0 and also write tests to ensure that it doesn't break again.

[orenyk]

Note that when the user reported the issue, that the import completed successfully. When I tried it with the following CSV content, the import did not complete successfully.

pants@pants.com,pants,mcpants,,1234567890,pants@pants.com,pants

EDIT whoops, forgot the header row

[orenyk]

Ok, it's a different NoMethodError, but we should fix the first one as well. Screenshot:

Looks like we need to import the UsersHelper since we're in a different controller? We'll deal with it when we deal with it :-).

[coollog]

okay, in branch 1094_importusers, I simply added helper UsersHelper into ImportUsersController and it solved the NoMethodError problem. However, the import is failing due to a Incomplete user information. Unable to find user in online directory (LDAP). error?

[coollog]

Alright, had to check for cas and ldap usage before using the ldap importing methods. When not using CAS, the username field was simply replaced with the email field. Finished and submitting pull request.